Messages in this thread | | | From | "Pan, Jacob jun" <> | Date | Tue, 16 Feb 2010 09:19:58 -0800 | Subject | RE: [PATCH 1/3] MFD: introduce lpc_sch for Intel SCH LPC bridge |
| |
>> >On Thu, Feb 11, 2010 at 12:26:19PM +0200, Denis Turischev wrote: >> >> Intel Poulsbo (SCH) chipset LPC bridge controller contains several >> >> functions. Creating and MFD driver for the LPC bridge controller allows >> >> simultaneous use of SMBus and GPIO interfaces on the SCH. >> >That looks like an nice patch to me. Before merging it, I'd like to get >> >Jacob's view on it though. Jacob, does moving the SCH SMBus driver to a >> >platform one look fine to you ? >> > >> [[JPAN]] i agree with merging gpio and smbus into lpc driver. the only >question >> i had was whether impact to the user space tools has been considered. iirc, >> there are sensors detect tools probe pci bus for smbus controllers, not sure >it >> does that for platform bus. > >That shouldn't be a problem. The PCI device is still present, so >sensors-detect will see it. Then it will load the required driver, and >that driver will instantiate i2c adapters. The script then probes all >i2c adapters regardless of who created them, so the exact driver >implementation doesn't matter. > [[JPAN]] thanks for explaining it, all made sense to me. looking at sensors-detect, it will still load isch driver for the same pci id. but how would it know it depends on the new lpc driver to set up resources? i can't see shared symbols.
}, { vendid => 0x8086, devid => 0x8119, procid => "Intel SCH", driver => "i2c-isch", },
| |