Messages in this thread Patch in this message | | | Subject | [PATCH -mm] Kill existing current task quickly | From | Minchan Kim <> | Date | Wed, 17 Feb 2010 00:59:17 +0900 |
| |
I am not sure why didn't we break the loop until now. As looking git log, I found it is removed by Nick at b78483a. He mentioned "introduced a problem". If I miss something, pz, correct me.
== CUT_HERE ==
[PATCH -mm] Kill existing current task quickly
If we found current task is existing but didn't set TIF_MEMDIE during OOM victim selection, let's stop unnecessary looping for getting high badness score task and go ahead for killing current.
This patch would make side effect skip OOM_DISABLE test. But It's okay since the task is existing and oom_kill_process doesn't show any killing message since __oom_kill_task will interrupt it in oom_kill_process.
Signed-off-by: Minchan Kim <minchan.kim@gmail.com> Cc: Nick Piggin <npiggin@suse.de> --- mm/oom_kill.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/mm/oom_kill.c b/mm/oom_kill.c index 3618be3..5c21398 100644 --- a/mm/oom_kill.c +++ b/mm/oom_kill.c @@ -295,6 +295,7 @@ static struct task_struct *select_bad_process(unsigned long *ppoints, chosen = p; *ppoints = ULONG_MAX; + break; } if (p->signal->oom_adj == OOM_DISABLE) -- 1.6.5
-- Kind regards, Minchan Kim
| |