lkml.org 
[lkml]   [2010]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] x86: set_personality_ia32() abuses TS_COMPAT


On Tue, 16 Feb 2010, Oleg Nesterov wrote:
>
> In fact I'd say this is not right, but fortunetely do_execve() can
> never return something which could confuse syscall_get_error().
> And apart from do_signal() we never check TS_COMPAT during return
> to user-mode.

But 'do_signal()' _can_ happen the first thing after an execve(), no?

And after we have switched to 32-bit mode, we _are_ inside a 32-bit system
call: the execve has "changed" from a 64-bit one to a 32-bit one.

So I really don't understand why you dislike TS_COMPAT here.

I understand not liking TS_COMPAT in the first place (it would be nice to
not have that flag at all), but considering that it exists, and it is
supposed to be set while in 32-bit system calls, setting it on a 32-bit
execve() seems to be the RightThing(tm) to do.

Linus


\
 
 \ /
  Last update: 2010-02-16 16:43    [from the cache]
©2003-2011 Jasper Spaans