Messages in this thread | | | Date | Tue, 16 Feb 2010 12:02:56 +0100 (CET) | From | Jaroslav Kysela <> | Subject | Re: bug list: range checking issues |
| |
On Tue, 16 Feb 2010, Clemens Ladisch wrote:
> This looks correct; the channels parameter is an interval, not a mask. > > if (!params->fifo_size) { > if (snd_mask_min(¶ms->masks[SNDRV_PCM_HW_PARAM_FORMAT]) == > snd_mask_max(¶ms->masks[SNDRV_PCM_HW_PARAM_FORMAT]) && > snd_mask_min(¶ms->masks[SNDRV_PCM_HW_PARAM_CHANNELS]) == > snd_mask_max(¶ms->masks[SNDRV_PCM_HW_PARAM_CHANNELS])) { > > Jaroslav, I guess this should have been snd_interval_min/max? > And shouldn't the parameters be accessed with hw_param_mask/interval?
Yes, the checks are not valid. Thanks for this notice. I fixed this issue in this commit:
http://git.alsa-project.org/?p=alsa-kernel.git;a=commitdiff;h=3be522a9514f58e0596db34898a514df206cadc5
Jaroslav
----- Jaroslav Kysela <perex@perex.cz> Linux Kernel Sound Maintainer ALSA Project, Red Hat, Inc.
| |