lkml.org 
[lkml]   [2010]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [net-next PATCH v4 1/3] sysctl: refactor integer handling proc code
Date
On Tuesday 16 February 2010 10:41:07 you wrote:

> > +
> > + if (!write && !first && left && !err)
> > + err = proc_put_newline(&buffer, &left);
> > + if (write && !err)
> > + err = proc_skip_wspace(&buffer, &left);
> > + if (err == -EFAULT /* do we really need to check for -EFAULT? */ ||
> > + (write && first))
> > + return err ? : -EINVAL;
>
> The logic here seems messy, adding one or two goto's may help?
>

OK, I'll give it a try.

What about the EFAULT check, is that really required?


\
 
 \ /
  Last update: 2010-02-16 11:55    [from the cache]
©2003-2011 Jasper Spaans