lkml.org 
[lkml]   [2010]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: bug list: range checking issues
    On Mon, Feb 15, 2010 at 03:47:24PM +0200, Alexey Dobriyan wrote:
    > On Mon, Feb 15, 2010 at 03:40:56PM +0300, Dan Carpenter wrote:
    > > kernel/pid_namespace.c +96 create_pid_namespace(26) warn: buffer overflow 'ns->pidmap' 1 <= 1
    >
    > What overflows exactly here?

    It's a false positive:

    smatch thinks the array ns->pidmap[] has ARRAY_SIZE() of 1 and i is 1.

    kernel/pid_namespace.c
    95 for (i = 1; i < PIDMAP_ENTRIES; i++)
    96 atomic_set(&ns->pidmap[i].nr_free, BITS_PER_PAGE);

    On my .config PIDMAP_ENTRIES is 0 so that line is never reached.

    regards,
    dan carpenter


    \
     
     \ /
      Last update: 2010-02-15 15:07    [W:2.697 / U:0.348 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site