lkml.org 
[lkml]   [2010]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 2/9] proc_devtree: fix THIS_MODULE without module.h
    From
    Date
    On Sat, 2010-02-13 at 09:02 -0700, Grant Likely wrote:
    > From: Jeremy Kerr <jeremy.kerr@canonical.com>
    >
    > Commit e22f628395432b967f2f505858c64450f7835365 introduced a build
    > breakage for ARM devtree work: the THIS_MODULE macro was added, but we
    > don't have module.h
    >
    > This change adds the necessary #include to get THIS_MODULE defined.
    > While we could just replace it with NULL (PROC_FS is a bool, not a
    > tristate), using THIS_MODULE will prevent unexpected breakage if we
    > ever do compile this as a module.
    >
    > Signed-off-by: Jeremy Kerr <jeremy.kerr@canonical.com>
    > Signed-off-by: Grant Likely <grant.likely@secretlab.ca>

    Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

    > ---
    >
    > fs/proc/proc_devtree.c | 1 +
    > 1 files changed, 1 insertions(+), 0 deletions(-)
    >
    > diff --git a/fs/proc/proc_devtree.c b/fs/proc/proc_devtree.c
    > index 0ec4511..f8650dc 100644
    > --- a/fs/proc/proc_devtree.c
    > +++ b/fs/proc/proc_devtree.c
    > @@ -11,6 +11,7 @@
    > #include <linux/stat.h>
    > #include <linux/string.h>
    > #include <linux/of.h>
    > +#include <linux/module.h>
    > #include <asm/prom.h>
    > #include <asm/uaccess.h>
    > #include "internal.h"




    \
     
     \ /
      Last update: 2010-02-14 07:13    [W:0.020 / U:0.768 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site