lkml.org 
[lkml]   [2010]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 2/2][RFC] tracing: Add extract out softirq names used by irq trace events
    From
    Date
    On Sat, 2010-02-13 at 11:39 +0100, Peter Zijlstra wrote:
    > On Fri, 2010-02-12 at 14:09 -0500, Steven Rostedt wrote:
    > > plain text document attachment (irq-events.patch)
    > > The irq trace events that map the softirq vectors to strings
    > > shows up in the format files as names. To allow binary parsers to
    > > be able to convert these names to their actual numbers, this patch
    > > extracts those enums.
    > >
    > > Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
    > >
    > > ---
    > > include/trace/events/irq.h | 11 +++++++++++
    > > 1 file changed, 11 insertions(+)
    > >
    > > Index: linux-trace.git/include/trace/events/irq.h
    > > ===================================================================
    > > --- linux-trace.git.orig/include/trace/events/irq.h 2010-02-12 13:29:44.000000000 -0500
    > > +++ linux-trace.git/include/trace/events/irq.h 2010-02-12 13:33:20.000000000 -0500
    > > @@ -7,6 +7,17 @@
    > > #include <linux/tracepoint.h>
    > > #include <linux/interrupt.h>
    > >
    > > +EXTRACT_TRACE_SYMBOL(HI_SOFTIRQ);
    > > +EXTRACT_TRACE_SYMBOL(TIMER_SOFTIRQ);
    > > +EXTRACT_TRACE_SYMBOL(NET_TX_SOFTIRQ);
    > > +EXTRACT_TRACE_SYMBOL(NET_RX_SOFTIRQ);
    > > +EXTRACT_TRACE_SYMBOL(BLOCK_SOFTIRQ);
    > > +EXTRACT_TRACE_SYMBOL(BLOCK_IOPOLL_SOFTIRQ);
    > > +EXTRACT_TRACE_SYMBOL(TASKLET_SOFTIRQ);
    > > +EXTRACT_TRACE_SYMBOL(SCHED_SOFTIRQ);
    > > +EXTRACT_TRACE_SYMBOL(HRTIMER_SOFTIRQ);
    > > +EXTRACT_TRACE_SYMBOL(RCU_SOFTIRQ);
    > > +
    >
    > Still sucks you have to explicitly iterate them all, and far away from
    > the actual definition site too, its just asking to get out of whack with
    > reality.

    We don't care about adding them near the definition site. We care about
    what is used. In this same file we have:

    #define softirq_name(sirq) { sirq##_SOFTIRQ, #sirq }
    #define show_softirq_name(val) \
    __print_symbolic(val, \
    softirq_name(HI), \
    softirq_name(TIMER), \
    softirq_name(NET_TX), \
    softirq_name(NET_RX), \
    softirq_name(BLOCK), \
    softirq_name(BLOCK_IOPOLL), \
    softirq_name(TASKLET), \
    softirq_name(SCHED), \
    softirq_name(HRTIMER), \
    softirq_name(RCU))

    Which uses the variables. If another softirq name is added, the
    TRACE_EVENT already misses it. That's not the point of the EXTRACT
    macro. The point is, if a TRACE_EVENT uses a name that is not a macro,
    this gives a way for it to display that value.

    -- Steve





    \
     
     \ /
      Last update: 2010-02-13 12:13    [W:0.027 / U:30.664 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site