lkml.org 
[lkml]   [2010]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 0/8] tip related: radix tree for spareseirq and logical flat clean up
    On 02/13/2010 04:30 PM, Eric W. Biederman wrote:
    > Yinghai Lu <yinghai@kernel.org> writes:
    >>
    >> Subject: [PATCH] x86: use vector_desc instead of vector_irq
    >>
    >> Eric pointed out that radix tree version of irq_to_desc will magnify delay on the path
    >> of handle_irq.
    >> use vector_desc to reduce the calling of irq_to_desc.
    >>
    >> next step: need to change all ack, mask, umask, eoi for all irq_chip to take irq_desc
    >>
    >> -v2: irq should be unsigned in 32bit handle_irq according to Eric
    >> also reset vector_desc for lguest in setup_irq
    >>
    >> Signed-off-by: Yinghai Lu <yinghai@kernel.org>
    >>
    >> Index: linux-2.6/arch/x86/kernel/irq_32.c
    >> ===================================================================
    >> --- linux-2.6.orig/arch/x86/kernel/irq_32.c
    >> +++ linux-2.6/arch/x86/kernel/irq_32.c
    >> @@ -76,7 +76,7 @@ static void call_on_stack(void *func, vo
    >> }
    >>
    >> static inline int
    >> -execute_on_irq_stack(int overflow, struct irq_desc *desc, int irq)
    >> +execute_on_irq_stack(int overflow, struct irq_desc *desc)
    >> {
    >> union irq_ctx *curctx, *irqctx;
    >> u32 *isp, arg1, arg2;
    >> @@ -189,24 +189,22 @@ asmlinkage void do_softirq(void)
    >
    > This looks like it will fail to build here.
    > Don't you need to update the assembly to use desc->irq instead
    > of the now removed irq parameter?

    ah, will fix that.

    YH


    \
     
     \ /
      Last update: 2010-02-14 01:55    [W:0.024 / U:0.376 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site