Messages in this thread | | | Date | Thu, 11 Feb 2010 07:22:49 -0500 | From | Christoph Hellwig <> | Subject | Re: [PATCH 2/4] block: support compat discard mode by default. |
| |
On Thu, Feb 11, 2010 at 01:57:50PM +0300, Dmitry Monakhov wrote: > Currently there are many filesystems which has implemented > discard support, but ssd discs not widely used yet. > Let's allow user to use compat discard mode by default. > After this feature is enabled by default for all devices which has > no native discard support it will be possible to use this feature > simply by passing appropriate mount option to fs (-odiscard in ext4)
So why do you even bother adding the DISCARD_FL_COMPAT option? This is a debug option that should probably be controlled at the block level, not anywhere near the filesystem.
| |