lkml.org 
[lkml]   [2010]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [BUGFIX][PATCH] memcg: fix oom killing a child process in an other cgroup
    On Fri, 12 Feb 2010 11:39:35 +0900
    Minchan Kim <minchan.kim@gmail.com> wrote:

    > On Fri, Feb 12, 2010 at 10:53 AM, KAMEZAWA Hiroyuki
    > <kamezawa.hiroyu@jp.fujitsu.com> wrote:
    > > This patch itself is againt mmotm-Feb10 but can be applied to 2.6.32.8
    > > without problem.
    > >
    > > ==
    > > From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
    > >
    > > Now, oom-killer is memcg aware and it finds the worst process from
    > > processes under memcg(s) in oom. Then, it kills victim's child at first.
    > > It may kill a child in other cgroup and may not be any help for recovery.
    > > And it will break the assumption users have...
    > >
    > > This patch fixes it.
    > >
    > > CC: stable@kernel.org
    > > CC: Minchan Kim <minchan.kim@gmail.com>
    > > CC: Balbir Singh <balbir@linux.vnet.ibm.com>
    > > CC: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
    > > Acked-by: David Rientjes <rientjes@google.com>
    > > Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
    > Reviewed-by: Minchan Kim <minchan.kim@gmail.com>
    >
    > Sorry for noise, Kame.
    >
    No problem. You give me a chance to consider other problems/dirtiness of codes.
    I continue review to make memcg cleaer.

    Thanks,
    -Kame



    \
     
     \ /
      Last update: 2010-02-12 03:47    [W:0.022 / U:2.192 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site