Messages in this thread |  | | | Date | Thu, 11 Feb 2010 13:44:05 -0800 (PST) | | From | David Rientjes <> | | Subject | Re: [PATCH] [2/4] SLAB: Separate node initialization into separate function |
| |
On Thu, 11 Feb 2010, Andi Kleen wrote:
> Index: linux-2.6.32-memhotadd/mm/slab.c > =================================================================== > --- linux-2.6.32-memhotadd.orig/mm/slab.c > +++ linux-2.6.32-memhotadd/mm/slab.c > @@ -1158,19 +1158,9 @@ free_array_cache: > } > } > > -static int __cpuinit cpuup_prepare(long cpu) > +static int slab_node_prepare(int node)
I still think this deserves a comment saying that slab_node_prepare() requires cache_chain_mutex, I'm not sure people interested in node hotadd would be concerned with whether the implementation needs to iterate slab caches or not.
Otherwise:
Acked-by: David Rientjes <rientjes@google.com>
|  |