lkml.org 
[lkml]   [2010]   [Feb]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 10/10] sound/soc/blackfin: Fix continuation line formats
    On Mon, Feb 1, 2010 at 12:08, Joe Perches wrote:
    > On Mon, 2010-02-01 at 14:47 +0000, Mark Brown wrote:
    >> On Sun, Jan 31, 2010 at 12:02:12PM -0800, Joe Perches wrote:
    >> > String constants that are continued on subsequent lines with \
    >> > are not good.
    >> >
    >> > Signed-off-by: Joe Perches <joe@perches.com>
    >>
    >> Gah, I thought I'd caught most of these when reviewing.  If you're using
    >> a script to pick this stuff up it'd be worth checking for extraneous
    >> continuations in the middle of code - outside of macros there's little
    >> call for it.
    >>
    >> Applied, thanks.
    >
    > There are a few false positives and probably a few missing using
    >
    >        grep -rP --include=*.[ch] '".*\\$' * | \
    >        awk '{ if ((gsub("\"", "\"") % 2) == 1) print $0; }'
    >
    > Most of the uses are __asm__ __volatile__ which could be
    > considered unsightly but don't impact logging messages.
    >
    > The rest could/should be fixed.

    *cough* checkpatch.pl *cough*

    the Blackfin alsa fixes all look good to me, thanks
    -mike
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-02-02 05:23    [W:0.024 / U:1.860 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site