lkml.org 
[lkml]   [2010]   [Feb]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/6] generic sys_ipc wrapper
    Christoph Hellwig wrote:
    > Add a generic implementation of the ipc demultiplexer syscall. Except for
    > s390 and sparc64 all implementations of the sys_ipc are nearly identical.
    >
    > There are slight differences in the types of the parameters, where mips
    > and powerpc as the only 64-bit architectures with sys_ipc use unsigned long
    > for the "third" argument as it gets casted to a pointer later, while it
    > traditionally is an "int" like most other paramters. frv goes even further
    > and uses unsigned long for all parameters execept for "ptr" which is a pointer
    > type everywhere. The change from int to unsigned long for "third" and back
    > to "int" for the others on frv should be fine due to the in-register calling
    > conventions for syscalls (we already had a similar issue with the generic
    > sys_ptrace), but I'd prefer to have the arch maintainers looks over this
    > in details.
    >
    > Except for that h8300, m68k and m68knommu lack an impplementation of the
    > semtimedop sub call which this patch adds, and various architectures have
    > different strategies for the SHMAT version 1 case which apparently never
    > gets used - at least on i386 it seems superflous as the compat code on
    > x86-64 and ia64 doesn't even bother to implement it.
    >
    >
    > Signed-off-by: Christoph Hellwig <hch@lst.de>

    For the m68knommup parts

    Acked-by: Greg Ungerer <gerg@uclinux.org>


    --
    ------------------------------------------------------------------------
    Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com
    SnapGear Group, McAfee PHONE: +61 7 3435 2888
    8 Gardner Close FAX: +61 7 3217 5323
    Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com


    \
     
     \ /
      Last update: 2010-02-02 02:07    [W:0.022 / U:0.436 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site