Messages in this thread | | | Date | Mon, 1 Feb 2010 14:29:42 -0800 | From | Stephen Hemminger <> | Subject | Re: [PATCH v3] sky2: receive dma mapping error handling |
| |
On Mon, 1 Feb 2010 22:27:41 +0100 Jarek Poplawski <jarkao2@gmail.com> wrote:
> @@ -1038,13 +1035,14 @@ static void tx_init(struct sky2_port *sky2) > { > struct sky2_tx_le *le; > > - sky2->tx_prod = sky2->tx_cons = 0; > + sky2->tx_prod = 0; > sky2->tx_tcpsum = 0; > sky2->tx_last_mss = 0; > > le = get_tx_le(sky2, &sky2->tx_prod); > le->addr = 0; > le->opcode = OP_ADDR64 | HW_OWNER; > + sky2->tx_cons = sky2->tx_prod; > sky2->tx_last_upper = 0; > }
Your change causes the initial element to be skipped. I want it to goto the hardware. It makes sure the upper bits of the first request are set (0).
I don't see what was wrong with my fix.
--
| |