Messages in this thread |  | | | From | Frans Pop <> | | Subject | Re: [PATCH 05/10] drivers/scsi/arcmsr: Fix continuation line formats | | Date | Mon, 1 Feb 2010 20:07:24 +0100 |
| |
> String constants that are continued on subsequent lines with \ > are not good. > Fix rebulid/rebuild typos > > Signed-off-by: Joe Perches <joe@perches.com>
Hmmm. Would it be an idea to also get rid of all the trailing spaces in the printks, or is that for another cleanup?
If you'd prefer a separate patch, I can do it.
A few random examples:
> drivers/scsi/arcmsr/arcmsr_hba.c | 49 > +++++++++++++++++-------------------- 1 files changed, 23 insertions(+), > 26 deletions(-) > > diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c > b/drivers/scsi/arcmsr/arcmsr_hba.c index 47d5d19..a0378d5 100644 > --- a/drivers/scsi/arcmsr/arcmsr_hba.c > +++ b/drivers/scsi/arcmsr/arcmsr_hba.c [...] + printk(KERN_NOTICE "arcmsr%d: wait 'flush adapter cache' timeout, retry count down = %d \n", + acb->host->host_no, retry_count); [...] + printk(KERN_NOTICE "arcmsr%d: isr get an illegal ccb command done acb = '0x%p'" "ccb = '0x%p' ccbacb = '0x%p' startdone = 0x%x" " ccboutstandingcount = %d \n" , acb->host->host_no [...] printk(KERN_NOTICE + "arcmsr%d: wait 'stop adapter background rebuild' timeout \n" , acb->host->host_no); [...] + printk(KERN_NOTICE "arcmsr%d: 'can not set diver mode \n" -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |