[lkml]   [2010]   [Feb]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 05/10] drivers/scsi/arcmsr: Fix continuation line formats
    On Mon, 2010-02-01 at 11:16 -0600, James Bottomley wrote:
    > On Sun, 2010-01-31 at 12:02 -0800, Joe Perches wrote:
    > > String constants that are continued on subsequent lines with \
    > > are not good.
    > Why? It's perfectly valid ansi C.

    Because they generally add unwanted spaces or tabs between
    words in logging messages. Just like these do.

    > but I also dislike your solution; I'd have split the string into two
    > separate ones and relied on compiler concatenation.

    Which Linus dislikes because it makes grepping difficult.

    > However, the point is that all three are perfectly legal C. Choosing
    > one form over another is something best left to the maintainers rather
    > than imposing one style by fiat.

    Which a patch does not do.

    > Consider this change veto'd unless you can get an explicit ack from the
    > current maintainer for changing their style.

    The current messages are defective.

     \ /
      Last update: 2010-02-01 18:33    [W:0.024 / U:11.004 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site