Messages in this thread | | | Date | Mon, 01 Feb 2010 05:14:32 -0800 (PST) | Subject | Re: [PATCH 00/68] ide2libata | From | David Miller <> |
| |
From: Alan Cox <alan@lxorguk.ukuu.org.uk> Date: Mon, 1 Feb 2010 12:58:45 +0000
>> > The old drivers contain a fair amount of crap, magic and gueswork so a >> > good deal of human analysis and testing is needed to move any change >> > around and prove it's real and valid not guesswork and fudging. >> >> And then once that hard work is done, we kind of just toss it >> for one side of the equation? > > I don't where you got that idea from. > > The "merge" makes it harder to maintain both, adds lots of ifdefs and > artificial divisions of code stuffed into include files. Its ugly as sin > and makes *both* sets of drivers harder to maintain.
I have not advocated the ifdef implementation.
I have advocated one where the data structures are actually the same, and there are no ifdefs.
Please reread my initial reply.
| |