lkml.org 
[lkml]   [2010]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [RFC PATCH] scatterlist: Initialize the dma_address field with invalid dma address
From
From: Nicolas Ferre <nicolas.ferre@atmel.com>
Date: Thu, 9 Dec 2010 14:15:14 +0100

> Initialize the the dma_address field so that it will be possible to test
> its value while using scatterlists. This field will be compatible with
> testing by dma_mapping_error().
>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>

Please don't do this, it's unjustified and it's going to kill performance.
Even if it were a good change, you should have used the invalid DMA
address definition defined by various architectures instead of a constant.

You should be aware of whether entries in a scatterlist have been setup
by your code path.


\
 
 \ /
  Last update: 2010-12-09 21:01    [W:0.076 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site