Messages in this thread | | | Date | Thu, 9 Dec 2010 14:52:24 +0100 (CET) | From | Jiri Kosina <> | Subject | Re: Aw: Re: [PATCH 0/5] HID: roccat: Achieve userspace notification on sysfs attribute creation |
| |
On Thu, 9 Dec 2010, Stefan Achatz wrote:
> > I have applied the series, and removed the #pragma pack ugliness. Thanks, >
> Hello Jiri, > Using my patch replacing the #pragma pack with the __packed macro would > have saved you some time: https://lkml.org/lkml/2010/11/27/14
Ah, missed that. Never mind.
> Just for the future: Whats better using the verbose version > __attribute__ ((__packed__)) or the macro __packed as I did?
I don't think I really care deeply here.
For some rationale why these shortcuts exist, please see commit 82ddcb0405704.
-- Jiri Kosina SUSE Labs, Novell Inc.
| |