Messages in this thread | | | Date | Wed, 8 Dec 2010 16:06:30 +0800 | From | Jens Axboe <> | Subject | Re: [PATCH 1/2] Don't merge different partition's IOs |
| |
On 2010-12-08 15:59, Satoru Takeuchi wrote: > Hi Jens, > > (2010/12/08 16:33), Jens Axboe wrote: >> On 2010-12-07 15:18, Satoru Takeuchi wrote: > >>> I hit on another approach. Although it doesn'tprevent any merge as Linus >>> preferred, it can fix the problem anyway. In this idea, in_flight is >>> incremented and decremented for the partition which the request belonged >>> to in its creation. It has the following merits. > > Revert is already finished. 2.6.37-rc-5 and latest stable kernel doesn't > contain Yasuaki's former logic. > > https://lkml.org/lkml/2010/10/24/118
Yes I know, that is why I said:
>> I really would prefer if we fixed up the patchset we ended up reverting. >> At least that had a purpose with growing struct request, since we saved >> on doing the partition lookups.
That I prefer we fix that code up, since I think it's the best solution to the problem.
-- Jens Axboe
| |