[lkml]   [2010]   [Dec]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v5 resend] OLPC: Add XO-1 suspend/resume support
On Fri,  3 Dec 2010 14:18:27 +0000 (GMT)
Daniel Drake <> wrote:

> Add code needed for basic suspend/resume of the XO-1 laptop.
> As distro kernels would prefer to build XO-1 support modular, we have
> had to export suspend_set_ops() and create an exported function for
> reading the address of the initial page table.
> Due to complications compiling asm into a module, the olpc-xo1.c file had to
> be renamed to have a name different from the target module name.
> Based on earlier work by Jordan Crouse, Andres Salomon, and others.

x86_64 allmodconfig gives me

{standard input}: Assembler messages:
{standard input}:300: Error: suffix or operands invalid for `mov'

due to

movl %rax,%eax # tmp70

in olpc_xo1_do_sleep().

Also, this checkpatch warning

WARNING: struct platform_suspend_ops should normally be const
#502: FILE: arch/x86/platform/olpc/xo1.c:106:
+static struct platform_suspend_ops xo1_suspend_ops = {

seems valid.

Also, something in today's linux-next has mucked up the x86 Kconfig:

drivers/platform/x86/Kconfig:422:error: recursive dependency detected!
drivers/platform/x86/Kconfig:422: symbol EEEPC_WMI depends on ACPI_WMI
drivers/platform/x86/Kconfig:438: symbol ACPI_WMI is selected by ACER_WMI
drivers/platform/x86/Kconfig:18: symbol ACER_WMI depends on LEDS_CLASS

 \ /
  Last update: 2010-12-08 23:53    [W:0.086 / U:7.564 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site