[lkml]   [2010]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[012/127] Staging: asus_oled: fix up my fixup for some sysfs attribute permissions
    2.6.32-stable review patch.  If anyone has any objections, please let us know.


    From: Greg Kroah-Hartman <>

    commit 515b4987ccd097cdf5416530b05fdf9e01afe95a upstream.

    They should be writable by root, not readable.
    Doh, stupid me with the wrong flags.

    Reported-by: Jonathan Cameron <>
    Cc: Jakub Schmidtke <>
    Signed-off-by: Greg Kroah-Hartman <>

    drivers/staging/asus_oled/asus_oled.c | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    --- a/drivers/staging/asus_oled/asus_oled.c
    +++ b/drivers/staging/asus_oled/asus_oled.c
    @@ -609,13 +609,13 @@ static ssize_t class_set_picture(struct

    #define ASUS_OLED_DEVICE_ATTR(_file) dev_attr_asus_oled_##_file

    -static DEVICE_ATTR(asus_oled_enabled, S_IRUSR | S_IRUGO,
    +static DEVICE_ATTR(asus_oled_enabled, S_IWUSR | S_IRUGO,
    get_enabled, set_enabled);
    -static DEVICE_ATTR(asus_oled_picture, S_IRUSR , NULL, set_picture);
    +static DEVICE_ATTR(asus_oled_picture, S_IWUSR , NULL, set_picture);

    -static DEVICE_ATTR(enabled, S_IRUSR | S_IRUGO,
    +static DEVICE_ATTR(enabled, S_IWUSR | S_IRUGO,
    class_get_enabled, class_set_enabled);
    -static DEVICE_ATTR(picture, S_IRUSR, NULL, class_set_picture);
    +static DEVICE_ATTR(picture, S_IWUSR, NULL, class_set_picture);

    static int asus_oled_probe(struct usb_interface *interface,
    const struct usb_device_id *id)

     \ /
      Last update: 2010-12-08 03:23    [W:0.048 / U:70.804 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site