lkml.org 
[lkml]   [2010]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[038/127] md: fix return value of rdev_size_change()
    2.6.32-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Justin Maggard <jmaggard10@gmail.com>

    commit c26a44ed1e552aaa1d4ceb71842002d235fe98d7 upstream.

    When trying to grow an array by enlarging component devices,
    rdev_size_store() expects the return value of rdev_size_change() to be
    in sectors, but the actual value is returned in KBs.

    This functionality was broken by commit
    dd8ac336c13fd8afdb082ebacb1cddd5cf727889
    so this patch is suitable for any kernel since 2.6.30.

    Signed-off-by: Justin Maggard <jmaggard10@gmail.com>
    Signed-off-by: NeilBrown <neilb@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/md/md.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/md/md.c
    +++ b/drivers/md/md.c
    @@ -1122,7 +1122,7 @@ super_90_rdev_size_change(mdk_rdev_t *rd
    md_super_write(rdev->mddev, rdev, rdev->sb_start, rdev->sb_size,
    rdev->sb_page);
    md_super_wait(rdev->mddev);
    - return num_sectors / 2; /* kB for sysfs */
    + return num_sectors;
    }


    @@ -1485,7 +1485,7 @@ super_1_rdev_size_change(mdk_rdev_t *rde
    md_super_write(rdev->mddev, rdev, rdev->sb_start, rdev->sb_size,
    rdev->sb_page);
    md_super_wait(rdev->mddev);
    - return num_sectors / 2; /* kB for sysfs */
    + return num_sectors;
    }

    static struct super_type super_types[] = {



    \
     
     \ /
      Last update: 2010-12-08 03:17    [W:4.435 / U:1.776 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site