lkml.org 
[lkml]   [2010]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[035/127] viafb: use proper register for colour when doing fill ops
    2.6.32-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>

    commit efd4f6398dc92b5bf392670df862f42a19f34cf2 upstream.

    The colour was written to a wrong register for fillrect operations.
    This sometimes caused empty console space (for example after 'clear')
    to have a different colour than desired. Fix this by writing to the
    correct register.
    Many thanks to Daniel Drake and Jon Nettleton for pointing out this
    issue and pointing me in the right direction for the fix.

    Fixes http://dev.laptop.org/ticket/9323

    Signed-off-by: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
    Cc: Joseph Chan <JosephChan@via.com.tw>
    Cc: Daniel Drake <dsd@laptop.org>
    Cc: Jon Nettleton <jon.nettleton@gmail.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/video/via/accel.c | 7 ++++---
    1 file changed, 4 insertions(+), 3 deletions(-)

    --- a/drivers/video/via/accel.c
    +++ b/drivers/video/via/accel.c
    @@ -277,11 +277,12 @@ static int hw_bitblt_2(void __iomem *eng
    writel(tmp, engine + 0x1C);
    }

    - if (op != VIA_BITBLT_COLOR)
    + if (op == VIA_BITBLT_FILL) {
    + writel(fg_color, engine + 0x58);
    + } else if (op == VIA_BITBLT_MONO) {
    writel(fg_color, engine + 0x4C);
    -
    - if (op == VIA_BITBLT_MONO)
    writel(bg_color, engine + 0x50);
    + }

    if (op == VIA_BITBLT_FILL)
    ge_cmd |= fill_rop << 24 | 0x00002000 | 0x00000001;



    \
     
     \ /
      Last update: 2010-12-08 03:15    [W:4.078 / U:0.304 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site