lkml.org 
[lkml]   [2010]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[048/127] firewire: core: fix an information leak
    2.6.32-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Stefan Richter <stefanr@s5r6.in-berlin.de>

    commit 137d9ebfdbaa45c01f9f0f6d5121ae6f1eb942bd upstream.

    If a device exposes a sparsely populated configuration ROM,
    firewire-core's sysfs interface and character device file interface
    showed random data in the gaps between config ROM blocks. Fix this by
    zero-initialization of the config ROM reader's scratch buffer.

    Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
    Cc: maximilian attems <max@stro.at>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/firewire/core-device.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/firewire/core-device.c
    +++ b/drivers/firewire/core-device.c
    @@ -463,6 +463,7 @@ static int read_bus_info_block(struct fw
    return -ENOMEM;

    stack = &rom[READ_BIB_ROM_SIZE];
    + memset(rom, 0, sizeof(*rom) * READ_BIB_ROM_SIZE);

    device->max_speed = SCODE_100;




    \
     
     \ /
      Last update: 2010-12-08 03:13    [W:2.372 / U:0.008 seconds]
    ©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site