lkml.org 
[lkml]   [2010]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[152/289] ASoC: Remove volatility from WM8900 POWER1 register
    2.6.36-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Mark Brown <broonie@opensource.wolfsonmicro.com>

    commit 6d212d8e86fb4221bd91b9266b7567ee2b83bd01 upstream.

    Not all bits can be read back from POWER1 so avoid corruption when using
    a read/modify/write cycle by marking it non-volatile - the only thing we
    read back from it is the chip revision which has diagnostic value only.
    We can re-add later but that's a more invasive change than is suitable
    for a bugfix.

    Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
    Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    sound/soc/codecs/wm8900.c | 6 ------
    1 file changed, 6 deletions(-)

    --- a/sound/soc/codecs/wm8900.c
    +++ b/sound/soc/codecs/wm8900.c
    @@ -188,7 +188,6 @@ static int wm8900_volatile_register(unsi
    {
    switch (reg) {
    case WM8900_REG_ID:
    - case WM8900_REG_POWER1:
    return 1;
    default:
    return 0;
    @@ -1236,11 +1235,6 @@ static __devinit int wm8900_i2c_probe(st
    goto err;
    }

    - /* Read back from the chip */
    - reg = snd_soc_read(codec, WM8900_REG_POWER1);
    - reg = (reg >> 12) & 0xf;
    - dev_info(&i2c->dev, "WM8900 revision %d\n", reg);
    -
    wm8900_reset(codec);

    /* Turn the chip on */



    \
     
     \ /
      Last update: 2010-12-08 02:35    [W:0.043 / U:30.620 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site