Messages in this thread | | | Subject | Re: [PATCH 2/6] trace syscalls: Remove redundant syscall_nr checks | From | Ian Munsie <> | Date | Wed, 08 Dec 2010 10:47:42 +1100 |
| |
Excerpts from Steven Rostedt's message of Wed Dec 08 01:54:42 +1100 2010: > On Tue, 2010-12-07 at 15:29 +1100, Ian Munsie wrote: > > From: Ian Munsie <imunsie@au1.ibm.com> > > > > With the ftrace events now checking if the syscall_nr is valid upon > > initialisation, there is no need to verify it when registering and > > unregistering the events, so remove the check. > > I still like to keep these checks. I don't mind redundant checks that > are in slow paths, as they may catch a bug on a change in the future. > > What you could do is change these to: > > if (WARN_ON_ONCE(num < 0 || num >= NR_syscalls))
Hi Steve,
Thanks for the feedback. Will update and resubmit.
Cheers, -Ian
| |