Messages in this thread | | | Date | Wed, 8 Dec 2010 07:19:35 +0900 | Subject | Re: [PATCH] compaction: Remove mem_cgroup_del_lru | From | Minchan Kim <> |
| |
On Wed, Dec 8, 2010 at 6:53 AM, Andrew Morton <akpm@linux-foundation.org> wrote: > On Wed, 8 Dec 2010 00:01:26 +0900 > Minchan Kim <minchan.kim@gmail.com> wrote: > >> del_page_from_lru_list alreay called mem_cgroup_del_lru. >> So we need to call it again. It makes wrong stat of memcg and >> even happen VM_BUG_ON hit. >> >> Cc: Balbir Singh <balbir@linux.vnet.ibm.com> >> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> >> Cc: Mel Gorman <mel@csn.ul.ie> >> Signed-off-by: Minchan Kim <minchan.kim@gmail.com> >> --- >> mm/compaction.c | 1 - >> 1 files changed, 0 insertions(+), 1 deletions(-) >> >> diff --git a/mm/compaction.c b/mm/compaction.c >> index 50b0a90..b0fbfdf 100644 >> --- a/mm/compaction.c >> +++ b/mm/compaction.c >> @@ -302,7 +302,6 @@ static unsigned long isolate_migratepages(struct zone *zone, >> /* Successfully isolated */ >> del_page_from_lru_list(zone, page, page_lru(page)); >> list_add(&page->lru, migratelist); >> - mem_cgroup_del_lru(page); >> cc->nr_migratepages++; >> nr_isolated++; >> > > err, yes, that looks bad. > > This bug is present in 2.6.35 and 2.6.36 afaict, so I tagged the fix > for -stable backporting.
Thanks, Andrew.
> >
-- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |