lkml.org 
[lkml]   [2010]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Use cpuops V1 04/11] x86: Use this_cpu_ops for current_cpu_data accesses
On Tue, 7 Dec 2010, Tejun Heo wrote:

> >> Ooh, was too fast. I think mixing the use of percpu accesses to
> >> cpu_info and the wrapper macro current_cpu_data is quite confusing.
> >> There aren't too many current_cpu_data users in x86 anyway. Can you
> >> please make the conversion complete? I'm moving the above misplaced
> >> chunk into 03 and not applying 04 for now.
> >
> > We cannot make that conversion complete since we cannot obtain the address
> > if we use a this_cpu operation. Then its better to drop this patch.
>
> No, I was talking about dropping current_cpu_data macro. We can use
> __this_cpu_ptr() for addresses. I just find it very confusing to mix
> current_cpu_data and using direct percpu accessors on cpu_info.

Hmmm... Ok 21 occurrences. So two patches: Conversion and then
this_cpu_ops. Or one doing both?



\
 
 \ /
  Last update: 2010-12-07 16:11    [W:1.756 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site