Messages in this thread | | | Date | Sun, 05 Dec 2010 22:04:55 -0500 | From | Rik van Riel <> | Subject | Re: [PATCH v4 3/7] move memcg reclaimable page into tail of inactive list |
| |
On 12/05/2010 12:29 PM, Minchan Kim wrote: > Golbal page reclaim moves reclaimalbe pages into inactive list > to reclaim asap. This patch apply the rule in memcg. > It can help to prevent unnecessary working page eviction of memcg.
The patch is right, but the description is wrong.
The rotate_reclaimable_page function moves just written out pages, which the VM wanted to reclaim, to the end of the inactive list. That way the VM will find those pages first next time it needs to free memory.
> Cc: Balbir Singh<balbir@linux.vnet.ibm.com> > Cc: KAMEZAWA Hiroyuki<kamezawa.hiroyu@jp.fujitsu.com> > Cc: Rik van Riel<riel@redhat.com> > Cc: KOSAKI Motohiro<kosaki.motohiro@jp.fujitsu.com> > Signed-off-by: Minchan Kim<minchan.kim@gmail.com>
Reviewed-by: Rik van Riel <riel@redhat.com>
-- All rights reversed
| |