lkml.org 
[lkml]   [2010]   [Dec]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] UDPCP Communication Protocol
From
Date
Le vendredi 31 décembre 2010 à 10:29 +0100, stefani@seibold.net a
écrit :
> + if (!list_empty(&usk->destlist)) {
> + state->sk = (struct sock *)usk;
> + state->dest = list_first_entry(&usk->destlist,
> + struct udpcp_dest, list);
> + sock_hold(state->sk);
> +
> + if (atomic_read(&state->sk->sk_refcnt) != 1) {
> + spin_unlock_irqrestore(&spinlock, flags);
> + return state;
> + }
> + atomic_dec(&state->sk->sk_refcnt);
> + }
> +

I am trying to understand what you are doing here.

It seems racy to me.

Apparently, what you want is to take a reference only if actual
sk_refcnt is not zero.

I suggest using atomic_inc_notzero(&state->sk->sk_refcnt) to avoid the
race in atomic_dec().



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2010-12-31 12:29    [W:0.125 / U:0.380 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site