[lkml]   [2010]   [Dec]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] GIC: Assign correct flow handler type in set_type callback
    On Thu, Dec 30, 2010 at 10:59 AM, Abhijeet Dharmapurikar
    <> wrote:
    > There are some interrupts that are true edge triggered in nature. If not
    > marked IRQ_PENDING, when disabled, they will be lost.
    > Use the set_type callback to assign the correct flow type handler for
    > shared peripheral interrupts.
    > Signed-off-by: Abhijeet Dharmapurikar <>
    > ---
    > This came to light when a edge triggered interrupt was supposed to wakeup the
    > sytem. The flow handler was set to the default handle_level_irq. On the resume
    > path the flow handler was invoked right after the I bit was cleared but before
    > each individual interrupts were enabled. This made the handle_level_irq ignore

    Why does the flow handler hit when the interrupt is disabled? Have you set
    IRQF_NOSUSPEND on this interrupt?

    > the interrupt (mask_ack it) and it was lost. handle_edge_irq does the right
    > thing by marking the interrupt as IRQ_PENDING and when the resume code gets to
    > enabling each interrupt this interrupt is resent again.

     \ /
      Last update: 2010-12-30 07:29    [W:0.020 / U:114.888 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site