Messages in this thread | | | Subject | Re: [PATVH] media, dvb, IX2505V: Remember to free allocated memory in failure path (ix2505v_attach()). | From | Malcolm Priestley <> | Date | Fri, 31 Dec 2010 01:19:34 +0000 |
| |
On Fri, 2010-12-31 at 00:11 +0100, Jesper Juhl wrote: > Hi, > > We may leak the storage allocated to 'state' in > drivers/media/dvb/frontends/ix2505v.c::ix2505v_attach() on error. > This patch makes sure we free the allocated memory in the failure case. > > > Signed-off-by: Jesper Juhl <jj@chaosbits.net> > --- > ix2505v.c | 1 + > 1 file changed, 1 insertion(+) > > Compile tested only. > > diff --git a/drivers/media/dvb/frontends/ix2505v.c b/drivers/media/dvb/frontends/ix2505v.c > index 55f2eba..fcb173d 100644 > --- a/drivers/media/dvb/frontends/ix2505v.c > +++ b/drivers/media/dvb/frontends/ix2505v.c > @@ -293,6 +293,7 @@ struct dvb_frontend *ix2505v_attach(struct dvb_frontend *fe, > ret = ix2505v_read_status_reg(state); > > if (ret & 0x80) { > + kfree(state); > deb_i2c("%s: No IX2505V found\n", __func__); > goto error; > } > Memory is freed in...
error: ix2505v_release(fe); return NULL;
via...
static int ix2505v_release(struct dvb_frontend *fe) { struct ix2505v_state *state = fe->tuner_priv;
fe->tuner_priv = NULL; kfree(state);
return 0; }
Regards
Malcolm
| |