[lkml]   [2010]   [Dec]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] taskstats: Use better ifdef for alignment
From: Jeff Mahoney <>
Date: Wed, 29 Dec 2010 19:12:08 -0500

> Commit 4be2c95d added a null field to align the taskstats structure but
> the discussion centered around ia64. The issue exists on other platforms
> with inefficient unaligned access and adding them piecemeal would be
> an unmaintainable mess.
> This patch uses Dave Miller's suggestion of using a combination of
> whether alignment is needed.
> Note that this will cause breakage on those platforms with applications
> like iotop which had hard-coded offsets into the packet to access the
> taskstats structure.
> The message seen on systems without the alignment fixes looks like:
> kernel unaligned access to 0xe000023879dca9bc, ip=0xa000000100133d10
> The addresses may vary but resolve to locations inside __delayacct_add_tsk.
> Reported-by: David S. Miller <>
> Signed-off-by: Jeff Mahoney <>

Acked-by: David S. Miller <>

 \ /
  Last update: 2010-12-31 01:25    [W:0.066 / U:0.700 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site