lkml.org 
[lkml]   [2010]   [Dec]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] taskstats: Use better ifdef for alignment
    From
    From: Jeff Mahoney <jeffm@suse.com>
    Date: Wed, 29 Dec 2010 19:12:08 -0500

    > Commit 4be2c95d added a null field to align the taskstats structure but
    > the discussion centered around ia64. The issue exists on other platforms
    > with inefficient unaligned access and adding them piecemeal would be
    > an unmaintainable mess.
    >
    > This patch uses Dave Miller's suggestion of using a combination of
    > CONFIG_64BIT && !CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS to determine
    > whether alignment is needed.
    >
    > Note that this will cause breakage on those platforms with applications
    > like iotop which had hard-coded offsets into the packet to access the
    > taskstats structure.
    >
    > The message seen on systems without the alignment fixes looks like:
    > kernel unaligned access to 0xe000023879dca9bc, ip=0xa000000100133d10
    >
    > The addresses may vary but resolve to locations inside __delayacct_add_tsk.
    >
    > Reported-by: David S. Miller <davem@davemloft.net>
    > Signed-off-by: Jeff Mahoney <jeffm@suse.com>

    Acked-by: David S. Miller <davem@davemloft.net>


    \
     
     \ /
      Last update: 2010-12-31 01:25    [W:0.019 / U:31.172 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site