lkml.org 
[lkml]   [2010]   [Dec]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH][zram] Do not check for init flag before starting I/O
On 12/30/2010 10:47 PM, Linus Torvalds wrote:
> On Thu, Dec 30, 2010 at 1:07 AM, Nitin Gupta<ngupta@vflare.org> wrote:
>> zram module is unusable without this fix.
>
> .. and apparently it oopses without it.
>
> See commit 7e24cce38a99f3 which added the code that you now remove.
> You were cc'd on it, I don't think we got any reply to it.
>

This commit shows oops in zram_inc_stat() which does not exist in
staging tree version of zram. Its actually a problem with zram version
as present in project's own repository where we allocate struct
zram_stats_cpu upon device initialization. OTOH, In mainline/staging
version of zram, we allocate struct stats upfront, so this oops cannot
happen in mainline version.

So, this commit is not even applicable for mainline/staging tree. My
bad, I didn't get a chance to review that patch.

> So no. I'm not taking this without way more explanations of why the
> original problem isn't a problem any more.
>

I will now end development on local project repository and sync it with
the mainline version, so all future development happens on
mainline/staging only, avoiding such confusions in future.


Nitin


\
 
 \ /
  Last update: 2010-12-30 20:05    [W:0.053 / U:0.544 seconds]
©2003-2014 Jasper Spaans. Advertise on this site