Messages in this thread | | | Date | Wed, 29 Dec 2010 10:02:27 +0100 | From | Marco Stornelli <> | Subject | Re: Bug in ext4/btrfs fallocate? |
| |
Il 29/12/2010 07:46, Andreas Dilger ha scritto: > On 2010-12-28, at 09:06, Marco Stornelli wrote: >> it seems that ext4/btrfs code for fallocate doesn't check for >> immutable/append inode flag. > > fallocate() probably shouldn't be allowed for immutable files, but it makes a lot of sense to call fallocate() on append-only files to avoid fragmentation, though it should only be called with the KEEP_SIZE flag. > > Cheers, Andreas >
It seems that only ocfs2 does that check, however I think not checking for immutable flag is an error, for the append case maybe you're right, doing this operation on append-only files has got sense.
Marco
| |