lkml.org 
[lkml]   [2010]   [Dec]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: Linux 2.6.37-rc8 (no fb)
    From
    On Wed, Dec 29, 2010 at 21:16, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
    > On Wed, 29 Dec 2010 11:40:04 -0800
    > Linus Torvalds <torvalds@linux-foundation.org> wrote:
    >> Chris - why did that lvds_ssc_freq thing suddenly start mattering? Can
    >> we please just disable spread-spectrum entirely? Or perhaps only if we
    >> notice that it was enabled already? Or something?
    >
    > Randy, Jeff and Alex, does the below help at all?  If so, it may be the
    > minimal fix we want for 2.6.37.

    Something broke your patch: whitespace instead of tabs.

    > diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios
    > index 2b20786..d27d016 100644
    > --- a/drivers/gpu/drm/i915/intel_bios.c
    > +++ b/drivers/gpu/drm/i915/intel_bios.c
    > @@ -263,6 +263,9 @@ parse_general_features(struct drm_i915_private *dev_priv,
    >                dev_priv->int_tv_support = general->int_tv_support;
    >                dev_priv->int_crt_support = general->int_crt_support;
    >                dev_priv->lvds_use_ssc = general->enable_ssc;
    > +               /* force disable until we can parse this correctly */

    This comment seems to imply that SSC wasn't used at all until recently, right?

    > +               if (IS_GEN5(dev) || IS_GEN6(dev))
    > +                       dev_priv->lvds_use_ssc = 0;

    Doesn't change anything here. Display stays blank.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-12-29 22:13    [W:0.020 / U:32.684 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site