lkml.org 
[lkml]   [2010]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC/PATCH 0/3] TWL4030 IRQ Changes
From
Date
Hi,

On Tue, 2010-12-28 at 17:41 +0000, Mark Brown wrote:
> > when we finally move to struct irq_data, the below could
> > be used. BTW, Thomas do you have any plans for exposing
> > irq_data_to_desc() ?
>
> The general idea is to move to struct irq_data sooner rather than later
> (all the existing MFD drivers have already been converted).

Great, I'll put this one together then.

> > -static void twl4030_sih_mask(unsigned irq)
> > +/* REVISIT define it here until IRQ Subsystem exports its implementation */
> > +#define irq_data_to_desc(data) container_of(data, struct irq_desc, irq_data)
>
> It looks like all you're using this for is to get the chip_data? If
> that is the case you're looking for irq_data_get_irq_chip_data() which
> will go directly from the irq_data to the chip_data. I may have missed
> something, I only scanned the code.

you're right, just didn't know that was such a helper. BTW, quite a big
name.

--
balbi



\
 
 \ /
  Last update: 2010-12-29 01:41    [W:0.037 / U:1.520 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site