Messages in this thread | | | Subject | Re: [RFC/PATCH 0/3] TWL4030 IRQ Changes | From | Felipe Balbi <> | Date | Wed, 29 Dec 2010 02:39:37 +0200 |
| |
Hi,
On Tue, 2010-12-28 at 17:41 +0000, Mark Brown wrote: > > when we finally move to struct irq_data, the below could > > be used. BTW, Thomas do you have any plans for exposing > > irq_data_to_desc() ? > > The general idea is to move to struct irq_data sooner rather than later > (all the existing MFD drivers have already been converted).
Great, I'll put this one together then.
> > -static void twl4030_sih_mask(unsigned irq) > > +/* REVISIT define it here until IRQ Subsystem exports its implementation */ > > +#define irq_data_to_desc(data) container_of(data, struct irq_desc, irq_data) > > It looks like all you're using this for is to get the chip_data? If > that is the case you're looking for irq_data_get_irq_chip_data() which > will go directly from the irq_data to the chip_data. I may have missed > something, I only scanned the code.
you're right, just didn't know that was such a helper. BTW, quite a big name.
-- balbi
| |