lkml.org 
[lkml]   [2010]   [Dec]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH V7 1/8] ntp: add ADJ_SETOFFSET mode bit
    On Sun, Dec 26, 2010 at 05:38:57AM +0900, Kuwahara,T. wrote:
    > After all, I'd prefer your earlier patchset. Leaving aside the
    > compatibility issue, there's no particular reason we have to re-use
    > the struct timex, which requires otherwise unnecessary conditional
    > branches as well as unit conversions. Don't you agree?

    Well, from my point of view of wanting to allow a user space clock
    servo to be able to adjust a hardware clock, it would be sufficient to
    offer a way to jump the clock and to adjust the frequency via one or
    perhaps two new system calls.

    That is indeed what I first suggested, and I still think it would be a
    clean and simple interface. The NTP call is quite gross, since it
    multiplexes a whole bunch of different functions through the timex
    structure.

    However, several reviewers on the lkml prefered to keep with the NTP
    interface. It offers the needed functionality and is already well
    established, despite its ugliness.

    To me, the proposed ADJ_SETOFFSET is a simple and logical extenstion
    of the NTP interface. Also, the implementation is straightforward. In
    contrast, using a special -INF value seems a bit obtuse to me.

    Richard


    \
     
     \ /
      Last update: 2010-12-26 15:17    [W:0.021 / U:30.584 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site