lkml.org 
[lkml]   [2010]   [Dec]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
DateSat, 25 Dec 2010 23:03:22 -0200
FromHenrique de Moraes Holschuh <>
SubjectRe: [PATCH] ACPI Thinkpad: We must always call va_end() after va_start() but do not do so in thinkpad_acpi.c::acpi_evalf()
On Fri, 24 Dec 2010, Jesper Juhl wrote:
> In drivers/platform/x86/thinkpad_acpi.c::acpi_evalf() we don't always call
> va_end() after va_start(). This patch corrects that.

Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>

Although that codepath is for a driver source bug, so arguably it would
be better to just BUG().

It has never been tested (or hit in practice), I think.

--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh


\
 
 \ /
  Last update: 2010-12-26 02:05    [from the cache]
©2003-2010