lkml.org 
[lkml]   [2010]   [Dec]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] Ceph: Fix a use-after-free bug in ceph_destroy_client().
    From
    On Sat, Dec 25, 2010 at 10:24 PM, Jesper Juhl <jj@chaosbits.net> wrote:
    > On Sat, 25 Dec 2010, richard -rw- weinberger wrote:
    >
    >> On Sat, Dec 25, 2010 at 7:17 PM, Jesper Juhl <jj@chaosbits.net> wrote:
    >> > Hello,
    >> >
    >> > In net/ceph/ceph_common.c::ceph_destroy_client() the pointer 'client' is
    >> > freed by kfree() and subsequently used in a call to dout() - use after
    >> > free bug.
    >>
    >> Not really. %p reads only the address of "client".
    >> kfree() does not alter this address.
    >>
    >
    > Ok, I see your point and you are correct. But still, the patch does not
    > change behaviour and it makes it absolutely clear that there's no
    > use-after-free bug, so it might still have merit... or?

    Your patch does not fix a bug.
    I would say it's a style fix.

    > --
    > Jesper Juhl <jj@chaosbits.net>            http://www.chaosbits.net/
    > Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
    > Plain text mails only, please.
    >
    >



    --
    Thanks,
    //richard
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-12-25 22:43    [W:0.021 / U:0.676 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site