lkml.org 
[lkml]   [2010]   [Dec]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] sched, cgroup: Use exit hook to avoid use-after-free crash
    From
    Date
    On Fri, 2010-12-24 at 18:07 +0100, Peter Zijlstra wrote:
    > On Fri, 2010-12-24 at 17:48 +0100, Mike Galbraith wrote:
    > > On Fri, 2010-12-24 at 16:59 +0100, Peter Zijlstra wrote:
    > >
    > > > So cgroup moves a task without calling cgroup_subsys::attach() which is
    > > > odd, but it does have an ::exit method, sadly it calls that _before_
    > > > re-assigning the task, which means we have to jump through some hoops.
    > >
    > > Could you do the move in cgroup_exit() in the CONFIG_PREEMPT case?
    >
    > I'm not really comfortable relying on that.. voluntary might just grow a
    > cond_resched() somewhere in the exit path and lead us down the same
    > path, also I think that !preempt smp might have the same race.

    Yeah, good point.

    -Mike




    \
     
     \ /
      Last update: 2010-12-24 18:27    [W:0.028 / U:32.452 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site