| Subject | Re: [Xen-devel] [PATCH 05/10] xen/setup: Set identity mapping for non-RAM E820 and E820 gaps. | From | Ian Campbell <> | Date | Wed, 22 Dec 2010 08:49:33 +0000 |
| |
On Tue, 2010-12-21 at 21:37 +0000, Konrad Rzeszutek Wilk wrote: > @@ -254,6 +282,12 @@ char * __init xen_memory_setup(void) > > xen_add_extra_mem(extra_pages); > > + /* > + * Set P2M for all non-RAM pages and E820 gaps to be identity > + * type PFNs. > + */ > + printk(KERN_INFO "Set %ld page(s) to 1-1 mapping.\n", > + xen_set_identity(&e820));
I had to look at this patch twice to find the caller of the xen_set_identity function here. I think spending a variable here would be worth the improved clarity.
Ian.
|