Messages in this thread | | | Date | Wed, 22 Dec 2010 12:32:58 -0200 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH -tip 2/4] [BUGFIX]perf: Fix strlist__parse_list to handle const string |
| |
Em Wed, Dec 22, 2010 at 01:57:39PM +0900, Masami Hiramatsu escreveu: > (2010/12/22 3:23), Arnaldo Carvalho de Melo wrote: > > Em Fri, Dec 17, 2010 at 10:12:06PM +0900, Masami Hiramatsu escreveu: > > Wouldn't be better to just stop changing the string by passing the > > length to strlist__parse_list_entry, etc? > > Yeah, it could be, but in that case, we need changing code > wider. > I think this is the simplest solution. :)
Ok, I'll try to fix it as I suggested, it it turns out difficult I'll apply the minimal fix.
> (Of course, we have to check dupstr flag on top of strlist__load too.) > > Thank you,
You're welcome,
- Arnaldo
| |