Messages in this thread | | | Date | Tue, 21 Dec 2010 20:44:25 -0800 | From | Greg KH <> | Subject | Re: [PATCH] pch_phub: add new device ML7213 |
| |
On Wed, Dec 22, 2010 at 01:33:14PM +0900, Tomoya MORINAGA wrote: > @@ -688,6 +720,7 @@ static int pch_phub_resume(struct pci_dev *pdev) > > static struct pci_device_id pch_phub_pcidev_id[] = { > {PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_PCH1_PHUB)}, > + {PCI_DEVICE(PCI_VENDOR_ID_ROHM, PCI_DEVICE_ID_ROHM_ML7213_PHUB)},
Put the device type here in the device table, so you don't have to check for it again in the probe function. That way you can save some code and keep things simpler and more obvious in the future when adding new device ids, that you also have to pick the type for it.
thanks,
greg k-h
| |