Messages in this thread | | | Subject | Re: [RFC PATCH 04/15] nohz_task: Stop the tick when the nohz task runs alone | From | Peter Zijlstra <> | Date | Tue, 21 Dec 2010 08:35:58 +0100 |
| |
On Tue, 2010-12-21 at 00:37 +0100, Frederic Weisbecker wrote: > On Mon, Dec 20, 2010 at 04:51:39PM +0100, Peter Zijlstra wrote: > > On Mon, 2010-12-20 at 16:24 +0100, Frederic Weisbecker wrote: > > > Check from the timer interrupt that we are a nohz task running > > > alone in the CPU and stop the tick if this is the case. > > > > > Does this verify that the tick has no other work to do? > > > > I see no list of things the tick does and a checklist that everything it > > does is indeed superfluous. > > In a subsequent patch we check if rcu also needs the tick. > For the rest, tick_nohz_stop_sched_tick() knows what to > do: keep the next tick or switch to nohz. > > Hm?
No, and that worries me, you don't even seem to know what the tick does and yet you're working on stopping it.
| |