[lkml]   [2010]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH net-next-2.6] bnx2: remove cancel_work_sync() from remove_one
    From: Tejun Heo <>
    Date: Tue, 21 Dec 2010 11:51:04 +0100

    > Yeah, I agree the synchronize_rcu() there would guarantee the actual
    > timer completion but as it currently stands it looks a bit too subtle.
    > Maybe it's a good idea to add a big fat comment explaining that the
    > the timer is guaranteed to stop after close() and how it's guaranteed
    > through synchronize_rcu() at the moment? Also, it might be better to
    > use synchronize_sched() there as timer synchronization through
    > synchronize_rcu() is more of a happy accident.

    I'm not sure the synchronize_*() is even necessary to guarentee
    watchdog timer completion.

    Like I said, I think the netif_tx_lock() held around both the timer
    function itself, and the del_timer() call, are sufficient.

    So, this ensures that the watchdog timer either runs to completion or
    sees the no-op scheduler attached and returns immediately without
    rescheduling the timer.

    In any event, I'm going to apply your bnx2 patch to net-next-2.6


     \ /
      Last update: 2010-12-21 21:21    [W:0.018 / U:0.060 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site