lkml.org 
[lkml]   [2010]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] drivers/media/video/v4l2-compat-ioctl32.c: Check the return value of copy_to_user
    Date
    On Tuesday 21 December 2010 02:18:06 Thiago Farina wrote:
    > diff --git a/drivers/media/video/v4l2-compat-ioctl32.c b/drivers/media/video/v4l2-compat-ioctl32.c
    > index e30e8df..55825ec 100644
    > --- a/drivers/media/video/v4l2-compat-ioctl32.c
    > +++ b/drivers/media/video/v4l2-compat-ioctl32.c
    > @@ -206,7 +206,9 @@ static struct video_code __user *get_microcode32(struct video_code32 *kp)
    > * user address is invalid, the native ioctl will do
    > * the error handling for us
    > */
    > - (void) copy_to_user(up->loadwhat, kp->loadwhat, sizeof(up->loadwhat));
    > + if (copy_to_user(up->loadwhat, kp->loadwhat, sizeof(up->loadwhat)))
    > + return NULL;
    > +
    > (void) put_user(kp->datasize, &up->datasize);
    > (void) put_user(compat_ptr(kp->data), &up->data);
    > return up;

    Did you read the comment above the code you changed?

    You can probably change this function to look at the return code of
    copy_to_user, but then you need to treat the put_user return code
    the same, and change the comment.

    Arnd


    \
     
     \ /
      Last update: 2010-12-21 19:27    [W:0.053 / U:1.036 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site