Messages in this thread |  | | | Date | Tue, 21 Dec 2010 09:54:18 +0800 | | Subject | Re: [PATCH] kthread_worker: Initialize dynamically allocated spinlock properly for lockdep | | From | Yong Zhang <> |
| |
On Tue, Dec 21, 2010 at 12:21 AM, Tejun Heo <tj@kernel.org> wrote: > Hello, > > On 12/20/2010 10:28 AM, Yong Zhang wrote: >> Subject: [PATCH] kthread_work: Make lockdep happy >> >> spinlock in kthread_worker and wait_queue_head in kthread_work >> both should be lockdep annotated. >> So change the interface to make it suiltable for CONFIG_LOCKDEP. >> >> Signed-off-by: Yong Zhang <yong.zhang0@gmail.com> >> --- >> I'm not sure if it's possible to define a worker on stack? >> So I left DEFINE_KTHREAD_WORKER() untouched. > > Yes, it can, I think.
Thanks for your confirmation, I will update the patch in V2.
>BTW, where are you using kthread_worker?
I don't have anything using kthread_worker, but go through the kernel and find ivtv is the only one. This is why I sent the untested patch :)
> I'm > planning to update its flush semantics similar to that of proper > workqueue so that it's less confusing and switching between the two is > easy, so its usage may change slightly soon, although conversion > shouldn't be difficult.
No problem. Now I just make the patch based on the current kthread_work*.
Thanks, Yong
-- Only stand for myself.
|  |